Add Azure Linux 4 to libraries Helix extra-platforms (linux_x64)#127613
Add Azure Linux 4 to libraries Helix extra-platforms (linux_x64)#127613richlander wants to merge 3 commits intomainfrom
Conversation
Adds azurelinux-4.0-helix-amd64 to the extra-platforms CoreCLR inner-loop queue set in eng/pipelines/libraries/helix-queues-setup.yml. Image tag verified present in image-info.dotnet-dotnet-buildtools-prereqs-docker-main.json. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/azp run runtime-extra-platforms |
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR expands the libraries Helix queue configuration for the linux_x64 CoreCLR inner-loop path by adding an Azure Linux 4.0 container-backed queue to the extra-platforms set, increasing opt-in OS coverage without changing the general/GA platform sets.
Changes:
- Add a new extra-platforms Helix queue entry for
AzureLinux.4.0.Amd64.Openusing theazurelinux-4.0-helix-amd64prereqs container image (digest-pinned). - Keep the host queue consistent with the existing container-backed extra-platforms entries (
AzureLinux.3.Amd64.Open). - Scope the change to the
isExtraPlatformsBuild && testScope != outerloopCoreCLR path only.
This comment has been minimized.
This comment has been minimized.
I can open a pull request to fix this. |
|
Thanks @vcsjones. I cannot get crypto-related failures past your eyes easily! Much appreciated. |
|
@richlander The The other test failure is QUIC related. This test is failing. It's testing that QUIC is supported on the underlying platform. It seems that the AZL4 image doesn't have a working version of MsQuic available, or for some other reason was not able to load. cc @dotnet/ncl |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
|
Ah, okay, it is known that |
|
@wfurt @ahmedilyasms what's the best pattern here? Disable the test for Azure Linux 4 or build libmsquic in the helix image? |
yes, I think so. I did ping MsQuic team about this and submitted PR for Ubuntu 26 but it may take some time to get it actually out. |
|
@wfurt -- what does "yes I think so" refer to? I gave two options. |
yes, disable tests. unless @ManickaP disagrees. I feel we can get the binaries in reasonable timeframe and I don't think it is worth do deal with all the building crap. The msquic binaries are all identical so if anything I would find a way how to get the package from previous release. |
|
Can you disable the tests for Azure Linux 4? |
I disabled it directly in this pull request for now. |
|
Note This review was generated by Copilot. 🤖 Copilot Code Review — PR #127613Holistic AssessmentMotivation: Justified — expanding Helix test coverage to Azure Linux 4.0 (pre-GA, opt-in via extra-platforms) is standard practice for early platform validation, consistent with how Debian 13, Fedora 44, and openSUSE 16.0 were added to the same section. Approach: Correct — the change follows the established pattern exactly: digest-pinned container image on the Summary: ✅ LGTM. This is a clean, minimal infrastructure change (2 lines across 2 files) that follows all established patterns and conventions. No correctness, performance, or compatibility concerns. Detailed Findings✅ Helix Queue Entry — Correct format and placementThe new entry at Verified:
✅ ActiveIssue Annotation — Proper test skip for known platform limitationAt [ActiveIssue("https://github.com/dotnet/runtime/issues/127658", typeof(PlatformDetection), nameof(PlatformDetection.IsAzureLinux4OrHigher))]Verified:
✅ Cross-cutting check — No other tests needing similar skipThe class-level ✅ Scope — Appropriately narrow
|
|
thanks @vcsjones . It seems like adding msquic is trivial so I changed my mind and posted dotnet/dotnet-buildtools-prereqs-docker#1648 If that works, we should be able to do all the testing. AZL crypto has been ..... interesting .... so I think there may be some value there. |
|
That didn't work @wfurt. AZL3 and 4 are incompatible. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
what error do you see? Copilot claims otherwise. |
Note
This PR description was AI/Copilot-generated.
Adds Azure Linux 4 to the libraries Helix extra-platforms queue set for
linux_x64(CoreCLR inner-loop) ineng/pipelines/libraries/helix-queues-setup.yml.Change
eng/pipelines/libraries/helix-queues-setup.ymllinux_x64Queue entry:
Host queue is
AzureLinux.3.Amd64.Open, matching all other container-backed entries in the same section (Debian 13, Fedora 44, openSUSE 16.0).Image availability
The exact tag
azurelinux-4.0-helix-amd64is present inimage-info.dotnet-dotnet-buildtools-prereqs-docker-main.json. Digest pinned in the queue string above.Scope
helix-platforms.ymlis intentionally not updated — those values are reserved for GA releases, and Azure Linux 4 has not yet GA'd. This change only adds opt-in coverage via the extra-platforms pipeline.CI
This change only affects the extra-platforms (
isExtraPlatformsBuild) path. After this PR is opened, run:References